Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IO concept for javascript #607

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Added IO concept for javascript #607

merged 5 commits into from
Oct 21, 2022

Conversation

ulyssear
Copy link
Contributor

@ulyssear ulyssear commented Oct 19, 2022 •
edited
Loading

What GitHub issue does this PR apply to?

Resolves #595

What changed and why?

Added input/output concept for javascript (ECMAScript 2023, 2021, 2020 and 2009).

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

A new issue may be created to add a new section for WebSockets in the IO concept.

@ulyssear ulyssear changed the title Added input output concept for javascript Added IO concept for javascript Oct 19, 2022
geekygirlsarah
geekygirlsarah approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! I'll merge it in. (Also I learned a couple of things about the console colors!)

Thanks for another JS contribution!

This now has me wondering if maybe JS should be broken up into "JS (Browser, version)" and "JS (Node, version)". But that sounds a bit much at the moment. I'd be curious to hear your thoughts!

@geekygirlsarah geekygirlsarah merged commit 2a205c5 into codethesaurus:main Oct 21, 2022
@ulyssear
Copy link
Contributor Author

This is good! I'll merge it in. (Also I learned a couple of things about the console colors!)

Thanks for another JS contribution!

This now has me wondering if maybe JS should be broken up into "JS (Browser, version)" and "JS (Node, version)". But that sounds a bit much at the moment. I'd be curious to hear your thoughts!

Thanks for your reviews and you're welcome :)

I understand, but I don't think it's necessary to add another version of JavaScript (yet) when it's familiar to work with Node.js for the purpose of doing JavaScript.

@geekygirlsarah
Copy link
Member

Alright, fair enough! I just know it allows some things that browser-based won't let you do. But we can keep with the current trend for now.

@ulyssear ulyssear deleted the javascript-input-output branch October 24, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafce25 cafce25 cafce25 left review comments

@geekygirlsarah geekygirlsarah geekygirlsarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Javascript] Add input/output
3 participants
@ulyssear @geekygirlsarah @cafce25